HIVE-29059: SHOW CREATE TABLE ignores all strings after tab character for VIEWs by cyanzheng2926 · Pull Request #6563 · apache/hive

cyanzheng2926 · 2026-06-25T08:46:31Z

What changes were proposed in this pull request?

Addresses the issue for HIVE-29059 when a view is created with actual tabs, the SHOW CREATE TABLE output would truncate all strings after the tab.

Why are the changes needed?

SHOW CREATE TABLE of a view's create comment containing tab characters should correctly display all characters without breaking its original syntax or semantic.

Does this PR introduce any user-facing change?

Yes.
When tab is present in the create view statement, running SHOW CREATE TABLE would truncate the output after the tab. e.g.:
CREATE TABLE t1 (val1 string, val2 string);
CREATE VIEW v1 AS SELECT * FROM t1 WHERE val1 = 'a '; -- There are tabs present at val1<tab>= 'a<tab>1';
SHOW CREATE TABLE v1;
-- This would originally output below:
+----------------------------------------------------+
| createtab_stmt |
+----------------------------------------------------+
| CREATE VIEW v1 AS SELECT t1.val1, t1.val2 FROM default.t1 WHERE t1.val1 |
+----------------------------------------------------+

After the fix, tabs outside string literals are replaced by explicit space to maintain syntax during copy, and tabs within string literals would be replaced with \t for pattern matching e.g.:
+----------------------------------------------------+
| createtab_stmt |
+----------------------------------------------------+
| CREATE VIEW v1 AS SELECT t1.val1, t1.val2 FROM default.t1 WHERE t1.val1 = 'a\t1' |
+----------------------------------------------------+

How was this patch tested?

Created show_create_table_tab_view.q which contains testing tab for several cases

… for views

Copilot

Pull request overview

Fixes HIVE-29059 where SHOW CREATE TABLE for VIEWs can truncate output after literal tab characters by escaping tab characters in the rendered VIEW DDL, and adds a qtest covering several tab-containing VIEW definitions.

Changes:

Escape literal tab characters (\t) in SHOW CREATE TABLE output for VIEWs.
Add a new clientpositive qtest that creates/views with tabs in whitespace and string literals and verifies \t escaping.
Add the corresponding LLAP expected output file for the new qtest.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/show/ShowCreateTableOperation.java`	Escapes tab characters in the generated CREATE VIEW statement before writing results.
`ql/src/test/queries/clientpositive/show_create_table_tab_view.q`	New qtest query file exercising tab characters in VIEW definitions and literals.
`ql/src/test/results/clientpositive/llap/show_create_table_tab_view.q.out`	New LLAP golden output validating `\t` escaping and non-view behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ayushtkn

minor comments, rest looks good

…testcases

…er_tab

cyanzheng2926 · 2026-06-29T01:36:43Z

Hi @ayushtkn thanks again for the review :) I've addressed all the suggested changes.

ayushtkn

Minor comment, rest LGTM

ayushtkn · 2026-06-29T02:47:45Z

  script_pipe.q,\
  scriptfile1.q,\
  select_transform_hint.q,\
+  show_create_table_tab_view.q,\


I don't think this is required, you can add a normal test, adding to these files is required for specific cases when u want LLAP or Tez, else by default it goes to normal CLI driver, drop this and move the q.out

Understood, thanks!

ayushtkn · 2026-06-29T10:08:54Z

      String command;
      if (table.isView()) {
-        command = ddlObj.getCreateViewCommand(table, desc.isRelative());
+        command = ddlObj.getCreateViewCommand(table, desc.isRelative()).replace("\t", "\\t");


I don't think the solution is correct. After this change, If a user copies this SHOW CREATE TABLE output to recreate the view, the execution will fail with a syntax error.
You can see the side effect directly in the .out file you provided:

CREATE VIEW `showcrt_tab_src_v` AS SELECT `showcrt_tab_src`.`val1`, `showcrt_tab_src`.`val2`, `showcrt_tab_src`.`val3` FROM `default`.`showcrt_tab_src` \tWHERE `showcrt_tab_src`.`val1`\t= 'a1' \tAND `showcrt_tab_src`.`val2`\t= 'b1'

Thanks for catching this, that makes sense. I'll update the fix and replace the with space for maintaining the correct syntax outside of string literals, and escape tabs with \t within the string literals for pattern matching. This should address the truncation without breaking syntax or pattern matching.

…ls with \t and outside string literals with space, updated associated tests

…reate_table_truncates_after_tab

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

+	AND val2	= 'b1';
+SHOW CREATE TABLE showcrt_tab_src_v;
+
+-- Pattern matching with tabs still need to return correct results


ayushtkn

Thinking again, I think the solution isn't cof

ayushtkn · 2026-07-01T02:34:53Z

+    for (int i = 0; i < sql.length(); i++) {
+      char c = sql.charAt(i);
+      if (quote == 0) { // outside string literal
+        if (c == '\'' || c == '"') {


I think hive supports ` as well, can u validate if it works with backtics

Hi @ayushtkn thanks for pointing this out. I've added tests for column identifiers with ` and tabs, and validated that ` needs to be treated differently from the string literals, since identifiers still need the literal tabs (instead of converting to \t) for pattern matching. Direct replacement with \t or space will fail at pattern matching or lose the original literal tab pattern. Thus removed the changes to sql before writing to DataOutputStream, and added an overload to the existing createFetchTask under BaseSemanticAnalyzer to make sure the sql is not splitted by tabs when reading.

…ing fetch task with SERIALIZATION_LAST_COLUMN_TAKES_REST

…er_tab

sonarqubecloud · 2026-07-01T10:15:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ayushtkn

LGTM

Thanx @cyanzheng2926 for the work here!!!

HIVE-29059: SHOW CREATE TABLE ignores all strings after tab character…

d6f0507

… for views

asf-ci-hive added the tests pending label Jun 25, 2026

ayushtkn requested a review from Copilot June 25, 2026 11:28

Copilot started reviewing on behalf of ayushtkn June 25, 2026 11:28 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread ql/src/test/queries/clientpositive/show_create_table_tab_view.q Outdated

Comment thread ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/show/ShowCreateTableOperation.java Outdated

asf-ci-hive added tests passed and removed tests pending labels Jun 25, 2026

ayushtkn reviewed Jun 25, 2026

View reviewed changes

Comment thread ql/src/test/queries/clientpositive/show_create_table_tab_view.q Outdated

Comment thread ql/src/test/queries/clientpositive/show_create_table_tab_view.q Outdated

Comment thread ql/src/test/queries/clientpositive/show_create_table_tab_view.q Outdated

cyanzheng2926 added 2 commits June 29, 2026 11:33

HIVE-29059: address review feedbacks on show_create_table_tab_view.q …

061c164

…testcases

Merge branch 'master' into HIVE-29059-show_create_table_truncates_aft…

af83d9d

…er_tab

asf-ci-hive added tests pending and removed tests passed labels Jun 29, 2026

ayushtkn reviewed Jun 29, 2026

View reviewed changes

removed test file from testconfiguration.properties

ce7d3f2

asf-ci-hive added tests unstable tests pending tests passed and removed tests pending tests unstable labels Jun 29, 2026

ayushtkn reviewed Jun 29, 2026

View reviewed changes

cyanzheng2926 added 2 commits June 30, 2026 17:53

HIVE-29059: revised implementation of replacing tabs in string litera…

8556281

…ls with \t and outside string literals with space, updated associated tests

Merge remote-tracking branch 'upstream/master' into HIVE-29059-show_c…

a65d9c4

…reate_table_truncates_after_tab

asf-ci-hive added tests pending tests unstable and removed tests passed tests pending labels Jun 30, 2026

ayushtkn requested a review from Copilot July 1, 2026 02:26

Copilot started reviewing on behalf of ayushtkn July 1, 2026 02:27 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread ql/src/test/queries/clientpositive/show_create_table_tab_view.q

AND val2 = 'b1';

SHOW CREATE TABLE showcrt_tab_src_v;

-- Pattern matching with tabs still need to return correct results

ayushtkn reviewed Jul 1, 2026

View reviewed changes

cyanzheng2926 added 3 commits July 1, 2026 18:57

HIVE-29059: Fix truncation after tab in show create table by configur…

b4c98ab

…ing fetch task with SERIALIZATION_LAST_COLUMN_TAKES_REST

minor formatting change

70864d0

Merge branch 'master' into HIVE-29059-show_create_table_truncates_aft…

a75be4e

…er_tab

asf-ci-hive added tests pending and removed tests unstable labels Jul 1, 2026

asf-ci-hive added tests passed and removed tests pending labels Jul 1, 2026

ayushtkn approved these changes Jul 3, 2026

View reviewed changes

ayushtkn merged commit bdde46e into apache:master Jul 3, 2026
6 checks passed

cyanzheng2926 deleted the HIVE-29059-show_create_table_truncates_after_tab branch July 3, 2026 10:26

Uh oh!

Conversation

cyanzheng2926 commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cyanzheng2926 commented Jun 29, 2026

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

ayushtkn Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

cyanzheng2926 Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

ayushtkn Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

cyanzheng2926 Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

ayushtkn Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

cyanzheng2926 Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 1, 2026

Quality Gate passed

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cyanzheng2926 commented Jun 25, 2026 •

edited

Loading

cyanzheng2926 Jul 1, 2026 •

edited

Loading